Bug 895 – SimpleOfdmWimaxPhy SNR computation

Bug 895 - SimpleOfdmWimaxPhy SNR computation


Summary:	SimpleOfdmWimaxPhy SNR computation

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wimax
Version:	pre-release
Hardware:	All All

Importance:	P3 major
Assigned To:	Mohamed Amine ISMAIL

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-04-26 10:02 UTC by Tom Henderson
Modified:	2010-04-30 13:16 UTC (History)
CC List:	3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tom Henderson 2010-04-26 10:02:39 UTC

line 336 in simple-ofdm-wimax-phy.cc:

 double Nwb = -114 + m_noiseFigure + 10 * log (GetBandwidth () / 1000000000) / 2.303;

leads to integer division before the log is taken, since GetBandwidth () returns an integer.  

The argument to log() needs to be turned into a floating point number, such as changing the divisor to 1000000000.0

Comment 1 Tom Henderson 2010-04-26 10:11:12 UTC

(In reply to comment #0)

> 
> The argument to log() needs to be turned into a floating point number, such as
> changing the divisor to 1000000000.0

(more precisely, the division needs to be turned into floating point)

Comment 2 Josh Pelkey 2010-04-29 13:36:39 UTC

(In reply to comment #1)
> (In reply to comment #0)
> 
> > 
> > The argument to log() needs to be turned into a floating point number, such as
> > changing the divisor to 1000000000.0
> 
> (more precisely, the division needs to be turned into floating point)

Amine, +1 on this one?  I can only push a change for this as late as Saturday morning.

Comment 3 Mohamed Amine ISMAIL 2010-04-30 04:50:06 UTC

+1

Comment 4 Josh Pelkey 2010-04-30 13:16:52 UTC

changeset 533be42b3c7f