Bug 891 – WiMAX device helper does not include propagation loss model by default

Bug 891 - WiMAX device helper does not include propagation loss model by default


Summary:	WiMAX device helper does not include propagation loss model by default

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wimax
Version:	pre-release
Hardware:	All All

Importance:	P5 normal
Assigned To:	Mohamed Amine ISMAIL

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-04-21 15:47 UTC by Tom Henderson
Modified:	2010-04-22 05:40 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
patch to fix the bug (5.86 KB, patch) 2010-04-22 05:39 UTC, Mohamed Amine ISMAIL	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tom Henderson 2010-04-21 15:47:05 UTC

WimaxHelper::Install () will create a SimpleOfdmWimaxChannel by default, but this channel will not have any propagation model associated with it.  This is in contrast to the Wifi models which by default will use the LogDistance model.  

I think there should be a default added (please pick one) so that all variants of WimaxHelper::Install() that do not pass in the channel explicitly will create an Ofdm channel with a suitable default loss model.  Having a default will IMO lead to less user surprise and will align with the Wifi default policy.  (I am filing this bug because I just debugged a program that had mobility models that were going unused due to no loss model being present).

It would be nice to update this before the ns-3.8 release since it is the first WiMAX release.

(These helpers need doxygen, by the way).

Comment 1 Mohamed Amine ISMAIL 2010-04-22 05:39:16 UTC

Created attachment 843 [details]
patch to fix the bug

This patch fixes the bug. It sets COST231 as the default propagation and loss model for SimpleOfdmWimaxChannel. It also provides new helper method to set the type of the propagation and loss model.

Comment 2 Mohamed Amine ISMAIL 2010-04-22 05:40:02 UTC

Fixed in changeset 6265