Bug 825 – UDP-Client-server's packet loss counter not properly reset

Bug 825 - UDP-Client-server's packet loss counter not properly reset


Summary:	UDP-Client-server's packet loss counter not properly reset

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	applications
Version:	pre-release
Hardware:	All All

Importance:	P5 normal
Assigned To:	Mohamed Amine ISMAIL

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-02-25 03:12 UTC by Antti Mäkelä
Modified:	2010-04-22 08:37 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
patch to fix the bug (1.62 KB, patch) 2010-04-22 08:37 UTC, Mohamed Amine ISMAIL	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Antti Mäkelä 2010-02-25 03:12:59 UTC

See

http://groups.google.com/group/ns-3-users/browse_thread/thread/56f46fe023d036d2

But in packet-loss-counter.cc,

memset (m_receiveBitMap,0,m_bitMapSize);

should be replaced with

memset (m_receiveBitMap,1,m_bitMapSize);

to make sure there won't be any extra packets counted as lost on the first round the bitmap is filled.

Comment 1 Josh Pelkey 2010-04-16 13:55:39 UTC

bug confirmed and proposed fix by author (Amine). pushing.

changeset ce10a6aced1e

Comment 2 Mohamed Amine ISMAIL 2010-04-22 08:37:22 UTC

Created attachment 844 [details]
patch to fix the bug

This patch fixes the bug. It initializes the bits of m_receiveBitMap to 1 (0xFF) instead of 0.