Bug 778 – OLSR ignores specified outgoing interface in RouteOutput()

Bug 778 - OLSR ignores specified outgoing interface in RouteOutput()


Summary:	OLSR ignores specified outgoing interface in RouteOutput()

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	routing
Version:	pre-release
Hardware:	All All

Importance:	P2 normal
Assigned To:	Gustavo J. A. M. Carneiro

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-12-15 23:50 UTC by Tom Henderson
Modified:	2010-02-03 10:18 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
patch enforcing the oif parameter (2.21 KB, patch) 2010-01-13 01:33 UTC, Tom Henderson	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tom Henderson 2009-12-15 23:50:06 UTC

OLSR does not do anything with the oif parameter, which may be set by
Socket::BindToDevice().  This was changed from an interface index to a device
pointer, but OLSR has not been handling this parameter yet.

Ptr<Ipv4Route>
RoutingProtocol::RouteOutput (Ptr<Packet> p, const Ipv4Header &header,
    Ptr<NetDevice> oif, Socket::SocketErrno &sockerr)

It says:
  // TBD:  oif is unused; can be used to restrict the outgoing interface
  // of the found route if application bound to a source interface

Comment 1 Tom Henderson 2010-01-13 01:33:40 UTC

Created attachment 721 [details]
patch enforcing the oif parameter

Comment 2 Gustavo J. A. M. Carneiro 2010-01-27 09:11:56 UTC

Comment on attachment 721 [details]
patch enforcing the oif parameter

No comments on the patch.  Looks plausible, and you know the new routing API better them I, so...

Comment 3 Josh Pelkey 2010-01-31 15:50:52 UTC

Gustavo, can you push this one?

Comment 4 Gustavo J. A. M. Carneiro 2010-02-03 10:18:31 UTC

Committed.

changeset:   5946:4fef76630d66
tag:         tip
user:        Tom Henderson <tomh@tomh.org>
date:        Wed Feb 03 15:17:27 2010 +0000
summary:     Bug 778 - OLSR ignores specified outgoing interface in RouteOutput()