Bug 729 – IPv6 over PPP

Bug 729 - IPv6 over PPP


Summary:	IPv6 over PPP

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	devices
Version:	ns-3-dev
Hardware:	All All

Importance:	P4 normal
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-10-22 05:13 UTC by Fabian Mauchle
Modified:	2009-11-12 03:24 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
patch (5.54 KB, patch) 2009-10-22 05:13 UTC, Fabian Mauchle	Details \| Diff
patch (replaces old one) (5.85 KB, patch) 2009-10-22 08:47 UTC, Fabian Mauchle	Details \| Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Fabian Mauchle 2009-10-22 05:13:23 UTC

Created attachment 636 [details]
patch

IPv6 can currently not communicate over a Point-to-Point link because its header has a hardcoded protocol value for IPv4.

The patch adds a protocol field to the Point-to-Point-Header and some methods to convert between PPP- and Ethernet- protocol numbers.

Comment 1 Sebastien Vincent 2009-10-22 07:51:55 UTC

Patch looks good.

Some (very very) minor comments:
- According to our naming convention: PPPtoETHER -> PppToEther and ETHERtoPPP -> EtherToPpp;
- \param and \return doxygen for PppToEther and EtherToPpp methods;
- Doxygen for m_protocol member.

(In reply to comment #0)
> Created an attachment (id=636) [details]
> patch
> 
> IPv6 can currently not communicate over a Point-to-Point link because its
> header has a hardcoded protocol value for IPv4.
> 
> The patch adds a protocol field to the Point-to-Point-Header and some methods
> to convert between PPP- and Ethernet- protocol numbers.
>

Comment 2 Fabian Mauchle 2009-10-22 08:47:41 UTC

Created attachment 637 [details]
patch (replaces old one)

Minor changes requested by Sebastien

Comment 3 Sebastien Vincent 2009-11-12 03:24:26 UTC

Merge in revision c305c6e122c9