|
Bugzilla – Full Text Bug Listing |
| Summary: | Inconsistent declaration of class/struct in <xxx>-wifi-managers | ||
|---|---|---|---|
| Product: | ns-3 | Reporter: | Quincy Tse <quincy.tse> |
| Component: | wifi | Assignee: | Nicola Baldo <nicola> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ns-bugs |
| Priority: | P5 | ||
| Version: | ns-3-dev | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: | Proposed patch. | ||
Created attachment 892 [details]
Proposed patch.
Hi Quincy, (In reply to comment #0) > Inconsistent declaration of the following as class/struct triggering static > analysis warnings. No actual functional deficiencies. Thank you for this patch. I agree that there is an inconsistency and I am ok in principle with the proposed change. The only thing is that, it seems that this bug addresses the same issue as bug 922 which was recently posted by you, though the prosed patches differ. Can you please point us which is the patch that you finally propose to apply? changeset: 6340:fe24c9edacb6 |
Inconsistent declaration of the following as class/struct triggering static analysis warnings. No actual functional deficiencies. * amrr-wifi-manager * onoe-wifi-manager * rraa-wifi-manager * aarfcd-wifi-manager * minstrel-wifi-manager ../src/devices/wifi/amrr-wifi-manager.cc:31:1: error: struct 'AmrrWifiRemoteStation' was previously declared as a class [-Wmismatched-tags] struct AmrrWifiRemoteStation : public WifiRemoteStation ^~~~~~ class In file included from ../src/devices/wifi/amrr-wifi-manager.cc:21: ../src/devices/wifi/amrr-wifi-manager.h:28:7: note: previous use is here class AmrrWifiRemoteStation; ^ 1 error generated. ../src/devices/wifi/onoe-wifi-manager.cc:30:1: error: struct 'OnoeWifiRemoteStation' was previously declared as a class [-Wmismatched-tags] struct OnoeWifiRemoteStation : public WifiRemoteStation ^~~~~~ class In file included from ../src/devices/wifi/onoe-wifi-manager.cc:21: ../src/devices/wifi/onoe-wifi-manager.h:28:7: note: previous use is here class OnoeWifiRemoteStation; ^ 1 error generated. etc.