Bug 876

Summary:	Tcp socket does not handle ShutdownRecv correctly
Product:	ns-3	Reporter:	Josh Pelkey <jpelkey>
Component:	internet	Assignee:	Josh Pelkey <jpelkey>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ns-bugs, tomh
Priority:	P5
Version:	ns-3-dev
Hardware:	All
OS:	All
Bug Depends on:
Bug Blocks:	833
Attachments:	simple fix

Description Josh Pelkey 2010-04-14 13:41:27 UTC

Discovered from bug 818, calling ShutdownRecv when using tcp-socket causes problems since TcpSocketImpl::ForwardUp simply returns before processing the event or action.  So state is not updated and packets are not processed after ShutdownRecv.

Comment 1 Josh Pelkey 2010-04-14 14:25:30 UTC

Created attachment 831 [details]
simple fix

The simplest fix.  Remove check for shutdownRecv in ForwardUp and just check right before each call to NotifyDataRecv.

Comment 2 Tom Henderson 2010-04-14 16:25:57 UTC

(In reply to comment #1)
> Created an attachment (id=831) [details]
> simple fix
> 
> The simplest fix.  Remove check for shutdownRecv in ForwardUp and just check
> right before each call to NotifyDataRecv.

Looks like the right thing to do, so +1 from me to commit so that you can unblock the other patches too and we can start to test this more.

Comment 3 Josh Pelkey 2010-04-14 16:59:03 UTC

changeset cc5b5294031f